brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #821: REST API for accessing adjuncts (includin...
Date Thu, 28 Sep 2017 13:12:15 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/821#discussion_r141589379
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/EntityInternal.java ---
    @@ -189,7 +189,7 @@
             void remove(AttributeSensor<?> attribute);
         }
     
    -    public interface FeedSupport {
    +    public interface FeedSupport extends Iterable<Feed> {
    --- End diff --
    
    Is it really necessary to extend from `Iterable` and have an `iterator()` method here
where we can get it from the `getFeed().iterator()` method (which always returns a collection)
? I don't see the benefit of creating this small shortcut


---

Mime
View raw message