brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes
Date Mon, 25 Sep 2017 08:59:11 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/810#discussion_r140721153
  
    --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/EnricherConfigSummary.java
---
    @@ -20,60 +20,24 @@
     
     import java.net.URI;
     import java.util.Map;
    -import java.util.Objects;
     
     import org.apache.brooklyn.config.ConfigKey;
     
    -import com.fasterxml.jackson.annotation.JsonProperty;
    -import com.fasterxml.jackson.databind.annotation.JsonSerialize;
    -import com.google.common.collect.ImmutableMap;
    -
    -public class EnricherConfigSummary extends ConfigSummary {
    +// TODO remove? this class has no value over its super
    --- End diff --
    
    agree, there is no reason to have more than one `ConfigSummary`


---

Mime
View raw message