brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #833: Fix PeriodicEffectorPolicy
Date Wed, 20 Sep 2017 10:51:44 GMT
Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/833#discussion_r139935476
  
    --- Diff: policy/src/main/java/org/apache/brooklyn/policy/action/AbstractScheduledEffectorPolicy.java
---
    @@ -233,8 +269,8 @@ public synchronized void run() {
                 Object result = entity.invoke(effector, resolved).getUnchecked();
                 LOG.debug("{}: Effector {} returned {}", new Object[] { this, effector.getName(),
result });
             } catch (RuntimeInterruptedException rie) {
    -            Thread.interrupted();
    -            // TODO sometimes this seems to hang the executor?
    +            // Gracefully stop
    +            Thread.currentThread().interrupt();
    --- End diff --
    
    Thanks, I couldn't remember the right way to handle this.


---

Mime
View raw message