brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From drigodwin <...@git.apache.org>
Subject [GitHub] brooklyn-library pull request #124: use external config provider for demo pa...
Date Wed, 13 Sep 2017 14:20:36 GMT
Github user drigodwin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/124#discussion_r138633960
  
    --- Diff: examples/simple-web-cluster/src/main/resources/visitors-creation-script.sql
---
    @@ -19,18 +19,22 @@
     create database visitors;
     use visitors;
     
    -# not necessary to create user if we grant (and not supported in some dialects)
    -# create user 'brooklyn' identified by 'br00k11n';
    -
    -grant usage on *.* to 'brooklyn'@'%' identified by 'br00k11n';
    -
    -# ''@localhost is sometimes set up, overriding brooklyn@'%', so do a second explicit
grant
    -grant usage on *.* to 'brooklyn'@'localhost' identified by 'br00k11n';
     
    +# the below will create user (and note create user not supported in some dialects)
    +grant usage on *.* to 'brooklyn'@'%' identified by '${config["creation.script.password"]}';
    --- End diff --
    
    As I mentioned on the other PR, this is script is used quite a few different places [here](https://brooklyn.apache.org/v/latest/blueprints/multiple-services.html)
for example. There should probably be a default so it doesn't break those places.


---

Mime
View raw message