brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #819: Improve config key descriptions
Date Wed, 13 Sep 2017 11:00:41 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/819#discussion_r138584470
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/Attributes.java ---
    @@ -52,11 +52,15 @@
     
         // TODO these should switch to being TemplatedStringAttributeSensorAndConfigKey
         BasicAttributeSensorAndConfigKey<String> DOWNLOAD_URL = new BasicAttributeSensorAndConfigKey<String>(
    -            String.class, "download.url", "URL pattern for downloading the installer
(will substitute things like ${version} automatically)");
    +            String.class, 
    +            "download.url", 
    +            "URL pattern for downloading the installer (will substitute things like ${version}
automatically)");
     
         @SuppressWarnings({ "unchecked", "rawtypes" })
         BasicAttributeSensorAndConfigKey<Map<String,String>> DOWNLOAD_ADDON_URLS
= new BasicAttributeSensorAndConfigKey(
    -            Map.class, "download.addon.urls", "URL patterns for downloading named add-ons
(will substitute things like ${version} automatically)");
    +            Map.class, 
    +            "download.addon.urls", 
    +            "URL patterns for downloading named add-ons (will substitute things like
${version} automatically)");
    --- End diff --
    
    Shouldn't it just say `uses FreeMarker templating format` to be consistent with the other
description below?


---

Mime
View raw message