brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #813: Added highlights to policy endpoint
Date Wed, 13 Sep 2017 08:36:59 GMT
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/813
  
    @m4rkmckenna re your general comment, a human client will use this to understand what's
going on.  currently adjuncts (policies etc) are opaque unless you look at logs or tasks (or
code).  highlights are an arbitrary set of summary info -- although with some conventions
-- which let an adjunct communicate to a user at a high level what it has been doing.  on
the premise that a little bit of sensibly distilled info is better than lots of raw info --
but sensible distillation does depend on the adjunct author a bit.  (i'd like to have activities
properly tagged to adjuncts as well, so we can also expose lots of "raw" info.)
    
    your point about javadoc is a good one so people know how to use these -- added in #818.
    
    i prefer the name `HighlightTuple` as there is nothing adjunct-specific about them, just
they are only used for adjuncts. 
    
    i also prefer `Objects.equal` and `hashCode` _but_ if your IDE generates this for you
or it has already been written i don't think it's worth the time to change ... doesn't create
any value for user!


---

Mime
View raw message