brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #791: Sync file system on temp file before moving it.
Date Fri, 08 Sep 2017 14:29:23 GMT
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/791
  
    very interesting link @geomacy - the stronger guarantee of `fcntl()` probably what the
activemq jni code does.
    
    i think this PR is good and your fix here for the problem caused by the also-needed #809
looks good.  i think merge though let's give @aledsage a few days to respond.
    
    as for any remaining risk ... the documentation for `sync` is unambiguous (and the post
is old) so i tend towards thinking this does what the API says, synching data with the disk.
 but let's remember this issue is here in case we come across systems where the OS/disk needs
additional configuration to ensure `sync` does what it says it does.


---

Mime
View raw message