brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rdowner <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #777: Removes `FIRST` sensors on children
Date Thu, 07 Sep 2017 11:09:44 GMT
Github user rdowner commented on the issue:

    https://github.com/apache/brooklyn-server/pull/777
  
    @ahgittin this appears to go against our published deprecation policy and is known to
break some blueprints.
    
    Your PR comments are making references to previous discussions, but it's not clear where
those are, and I haven't been able to find them. Example: `as comments there suggested` in
the first comment; `the new "primary" model` is mentioned in your last commit but no explanation
of this model; `causes important blueprints to fail` but does not say which ones. So unfortunately
I don't yet understand why this breaking change is needed.
    
    I think we should prepare a response (explanation, workaround, new best practice recommendation)
to the fact that we've broken some of our user's blueprints, with a clear justification of
why it had to be done. I'd like to see this discussed on the mailing list, and noted in [the
release notes](https://github.com/apache/brooklyn-docs/blob/master/guide/misc/release-notes.md),
and documentation too.
    
    Thanks


---

Mime
View raw message