Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-791-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-791-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server issue #791: Sync file system on temp file before moving it.
Content-Type: text/plain
Message-Id: <20170814090053.C02A1DFC47@git1-us-west.apache.org>
Date: Mon, 14 Aug 2017 09:00:53 +0000 (UTC)
archived-at: Mon, 14 Aug 2017 09:00:56 -0000

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/791
  
    @geomacy not convinced it's worth the effort of trying to mock the `FileDescriptor` to simulate a `SyncFailedException`. If we were doing more than retry + propagate, then maybe it would. But the current logic is pretty simple.
    
    One can mock final classes with Mockito v2 (we're on v2.7.12 currently): https://stackoverflow.com/a/40018295/1393883, but you need to add a config file to change the `MockMaker`.
    
    I think this is good as-is.
    
    Have you tried running the integration tests, as well as the unit tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---