brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #799: Uninstall bundles on error
Date Tue, 29 Aug 2017 15:32:41 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/799#discussion_r135827259
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
    @@ -1464,8 +1495,8 @@ public void addTypesFromBundleBom(String yaml, ManagedBundle bundle,
boolean for
         }
         
         @Override @Beta
    -    public Collection<Throwable> validateType(RegisteredType typeToValidate) {
    -        ReferenceWithError<RegisteredType> result = resolve(typeToValidate);
    +    public Collection<Throwable> validateType(RegisteredType typeToValidate, RegisteredTypeLoadingContext
constraint) {
    --- End diff --
    
    that context object is used primarily to constrain how loading can occur, e.g. specifying
required supertypes, already encountered types in type hierarchy (to prevent loop), classpath,
etc, that's why


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message