brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #799: Uninstall bundles on error
Date Tue, 29 Aug 2017 15:27:46 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/799#discussion_r135825675
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
    @@ -496,15 +500,17 @@ public static VersionedName getVersionedName(Map<?,?> catalogMetadata,
boolean r
     
         /** See comments on {@link #collectCatalogItemsFromItemMetadataBlock(String, ManagedBundle,
Map, List, boolean, Map, int, boolean)};
          * this is a shell around that that parses the `brooklyn.catalog` header on the BOM
YAML file */
    -    private void collectCatalogItemsFromCatalogBomRoot(String yaml, ManagedBundle containingBundle,
List<CatalogItemDtoAbstract<?, ?>> result, boolean requireValidation, Map<?,
?> parentMeta, int depth, boolean force) {
    +    private void collectCatalogItemsFromCatalogBomRoot(String yaml, ManagedBundle containingBundle,

    +        List<CatalogItemDtoAbstract<?, ?>> resultLegacyFormat, Map<RegisteredType,
RegisteredType> resultNewFormat, 
    --- End diff --
    
    agree


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message