brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #799: Uninstall bundles on error
Date Tue, 29 Aug 2017 13:26:36 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/799#discussion_r135766866
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
    @@ -1464,8 +1495,8 @@ public void addTypesFromBundleBom(String yaml, ManagedBundle bundle,
boolean for
         }
         
         @Override @Beta
    -    public Collection<Throwable> validateType(RegisteredType typeToValidate) {
    -        ReferenceWithError<RegisteredType> result = resolve(typeToValidate);
    +    public Collection<Throwable> validateType(RegisteredType typeToValidate, RegisteredTypeLoadingContext
constraint) {
    --- End diff --
    
    Out of interest, why is this called "constraint"? (I see it's called "constraint" consistently
all the way through the code, until we get to `BrooklynTypePlanTransformer.create()`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message