Return-Path: <dev-return-26319-archive-asf-public=cust-asf.ponee.io@brooklyn.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 6710F200CD6
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 31 Jul 2017 19:18:10 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 63F85165927; Mon, 31 Jul 2017 17:18:10 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id D14C3165922
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 31 Jul 2017 19:18:09 +0200 (CEST)
Received: (qmail 2239 invoked by uid 500); 31 Jul 2017 17:18:09 -0000
Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.apache.org>
List-Post: <mailto:dev@brooklyn.apache.org>
List-Id: <dev.brooklyn.apache.org>
Reply-To: dev@brooklyn.apache.org
Delivered-To: mailing list dev@brooklyn.apache.org
Received: (qmail 2226 invoked by uid 99); 31 Jul 2017 17:18:08 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Jul 2017 17:18:08 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 9FA7FE02E0; Mon, 31 Jul 2017 17:18:08 +0000 (UTC)
From: m4rkmckenna <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-782-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-782-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #782: Adds `PUT /applications/{appid}`
Content-Type: text/plain
Message-Id: <20170731171808.9FA7FE02E0@git1-us-west.apache.org>
Date: Mon, 31 Jul 2017 17:18:08 +0000 (UTC)
archived-at: Mon, 31 Jul 2017 17:18:10 -0000

Github user m4rkmckenna commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/782#discussion_r130405178
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalEntityManager.java ---
    @@ -143,12 +153,24 @@ public EntityTypeRegistry getEntityTypeRegistry() {
             if (!isRunning()) throw new IllegalStateException("Management context no longer running");
             return entityTypeRegistry;
         }
    +
    +    @Override
    +    public <T extends Entity> T createEntity(EntitySpec<T> spec) {
    +        return createEntity(spec, Optional.absent());
    +    }
         
    +    @Beta
         @SuppressWarnings("unchecked")
         @Override
    -    public <T extends Entity> T createEntity(EntitySpec<T> spec) {
    +    public <T extends Entity> T createEntity(EntitySpec<T> spec, Optional<String> entityId) {
    +        if (entityId.isPresent()) {
    +            if (!ENTITY_ID_PATTERN.matcher(entityId.get()).matches()) {
    +                throw new IllegalArgumentException("Invalid entity id '"+entityId.get()+"'");
    --- End diff --
    
    This exception text is never returned so its hard to diagnose the issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---