Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: m4rkmckenna <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-782-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-782-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #782: Adds `PUT /applications/{appid}`
Content-Type: text/plain
Message-Id: <20170731171803.DA29AE02E0@git1-us-west.apache.org>
Date: Mon, 31 Jul 2017 17:18:03 +0000 (UTC)
archived-at: Mon, 31 Jul 2017 17:18:05 -0000

Github user m4rkmckenna commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/782#discussion_r130405571
  
    --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/ApplicationApi.java ---
    @@ -110,15 +112,32 @@ public Response createFromYaml(
                         required = true)
                 String yaml);
     
    +    @Beta
    +    @PUT
    +    @Path("/{application}")
    +    @Consumes({"application/x-yaml",
    +            // see http://stackoverflow.com/questions/332129/yaml-mime-type
    +            "text/yaml", "text/x-yaml", "application/yaml"})
    +    @ApiOperation(
    +            value = "[BETA] Create and start a new application from YAML, with the given id",
    +            response = org.apache.brooklyn.rest.domain.TaskSummary.class
    +    )
    +    @ApiResponses(value = {
    +            @ApiResponse(code = 404, message = "Undefined entity or location"),
    +            @ApiResponse(code = 409, message = "Application already registered")
    --- End diff --
    
    409 is not returned when there is an id clash


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---