Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: geomacy <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-746-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-746-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles
Content-Type: text/plain
Message-Id: <20170714105145.A09E9DFC28@git1-us-west.apache.org>
Date: Fri, 14 Jul 2017 10:51:44 +0000 (UTC)
archived-at: Fri, 14 Jul 2017 10:51:48 -0000

Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/746#discussion_r127412080
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiManager.java ---
    @@ -372,33 +376,46 @@ public synchronized Bundle registerBundle(CatalogBundle bundleMetadata) {
         // it probably works even if that is true, but we should consider what to do;
         // possibly remove that other capability, so that bundles with BOMs _have_ to be installed via this method.
         // (load order gets confusing with auto-scanning...)
    -    public List<? extends CatalogItem<?,?>> loadCatalogBom(Bundle bundle) {
    -        return MutableList.copyOf(loadCatalogBom(mgmt, bundle));
    +    public List<? extends CatalogItem<?,?>> loadCatalogBomLegacy(Bundle bundle) {
    --- End diff --
    
    This isn't called now that you've removed the `CatalogBomScanner`, so you can remove it and the method below as well, _and_ get rid of the `legacy` parameter in `loadCatalogBomInternal`, and also remove `legacy` methods in `CatalogBundleLoader`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---