brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #778: Adds ‘deploymentUid’
Date Tue, 25 Jul 2017 16:32:08 GMT
GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/778

    Adds ‘deploymentUid’

    As discussed on the mailing list: https://lists.apache.org/thread.html/8eb58818d3ba50cfa5d5111363258cfe8529a76d17d45dc01823e0ba@%3Cdev.brooklyn.apache.org%3E
    
    This PR adds support for deploying YAML apps via the rest api, to include `&deploymentUid=...`.
This gets turned into a config key named `org.apache.brooklyn.deploymentUid` set on the app
being deployed.
    
    If there is already an app in existence with that deploymentUid, then the deployment fails
(*before* creating the entity).
    
    ---
    An alternative (simpler) implementation would be to allow the internal entity-id to be
specified via such a query parameter. There is already code to fail-fast if an entity with
a given id already exists.
    
    However, we removed (the deprecated) support for supplying the entity id in the `EntitySpec`.
We'd presumably have to add that back in (perhaps as "internal", somehow, rather than on the
main `EntitySpec` class).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server adds-deploymentUid

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/778.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #778
    
----
commit 7a32e94edaddf3ba6c8616d4af8cb6b2930797ab
Author: Aled Sage <aled.sage@gmail.com>
Date:   2017-07-25T16:25:31Z

    Adds ‘deploymentUid’

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message