brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bostko <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #757: [WIP] BROOKLYN-519 no BasicSpecParameter ...
Date Fri, 07 Jul 2017 09:49:31 GMT
GitHub user bostko opened a pull request:

    https://github.com/apache/brooklyn-server/pull/757

    [WIP] BROOKLYN-519 no BasicSpecParameter serialization

    BasicSpecParameters are only consumed in API
     and no need to keep them or keep their state.
    
    - TODO rebind tests
    
    - TODO test deserialization of a catalog item with
      brooklyn.parameters in it.
    
    - Long term TODO - not serializing SpecParameters.
      (Will need bigger discussion in Apache Brooklyn mailing list)
      Two ways to do that is either by using @XStreamOmitField or
      by setting AbstractBrooklynObjectSpec#parameters transient.
      However `transient' change besides not serializing parameters
      it also do not deserialize the parameters field which cause a backward compatibility
problem.
    
      Backward compatibility with transient parameters
      reproduceable in test `org.apache.brooklyn.entity.group.EntitySpecRebindTest`.
      Causing problem with class object references deserialization, see https://x-stream.github.io/graphs.html

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bostko/brooklyn-server serialize-basic-parameters

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/757.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #757
    
----
commit 968764765b82f034d21e908bb60e26dfd685e722
Author: Valentin Aitken <bostko@gmail.com>
Date:   2017-07-05T15:43:34Z

    BROOKLYN-519 no BasicSpecParameter serialization
    
    BasicSpecParameters are only consumed in API
     and no need to keep them or keep their state.
    
    - TODO rebind tests
    
    - TODO test deserialization of a catalog item with
      brooklyn.parameters in it.
    
    - TODO not serializing SpecParameters.
      Two ways to do that is either by using @XStreamOmitField or
      by setting AbstractBrooklynObjectSpec#parameters transient.
      However `transient' change besides not serializing parameters
      it also do not deserialize the parameters field which cause a backward compatibility
problem.
    
      Backward compatibility with transient parameters
      reproduceable in test org.apache.brooklyn.entity.group.EntitySpecRebindTest.
      Causing problem with class object references deserialization, see https://x-stream.github.io/graphs.html

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message