brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m4rkmckenna <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #782: Adds `PUT /applications/{appid}`
Date Fri, 28 Jul 2017 10:05:09 GMT
Github user m4rkmckenna commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/782#discussion_r130056079
  
    --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java
---
    @@ -101,6 +105,14 @@
         @Context
         private UriInfo uriInfo;
     
    +    /**
    +     * Only lower-case letters and digits; min 10 chars; max 1024 chars.
    +     * 
    +     * We are this extreme because some existing entity implementations rely on the entity-id
format 
    +     * for use in hostnames, etc.
    +     */
    +    private final Pattern appIdPattern = Pattern.compile("[a-z0-9]{10,1022}");
    --- End diff --
    
    This validation should probably also be deeper ... somewhere in mgmt context


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message