brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles
Date Mon, 17 Jul 2017 10:28:43 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/746#discussion_r127674944
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java
---
    @@ -81,22 +91,54 @@ public CatalogBundleLoader(Predicate<Bundle> applicationsPermitted,
ManagementCo
             if (null != bom) {
                 LOG.debug("Found catalog BOM in {} {} {}", CatalogUtils.bundleIds(bundle));
                 String bomText = readBom(bom);
    -            String bomWithLibraryPath = addLibraryDetails(bundle, bomText);
    -            catalogItems = this.managementContext.getCatalog().addItems(bomWithLibraryPath,
mb);
    -            for (CatalogItem<?, ?> item : catalogItems) {
    -                LOG.debug("Added to catalog: {}, {}", item.getSymbolicName(), item.getVersion());
    +            if (mb==null) {
    +                LOG.warn("Bundle "+bundle+" containing BOM is not managed by Brooklyn;
using legacy item installation");
    +                legacy = true;
    +            }
    +            if (legacy) {
    --- End diff --
    
    yep


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message