brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles
Date Wed, 12 Jul 2017 08:19:07 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/746#discussion_r126891275
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/typereg/RegisteredTypes.java ---
    @@ -125,21 +178,52 @@ public static RegisteredType bean(@Nonnull String symbolicName,
@Nonnull String
         }
         /** Convenience for {@link #bean(String, String, TypeImplementationPlan)} when there
is a single known java signature/super type */
         public static RegisteredType bean(@Nonnull String symbolicName, @Nonnull String version,
@Nonnull TypeImplementationPlan plan, @Nonnull Class<?> superType) {
    -        if (superType==null) log.warn("Deprecated use of RegisteredTypes API passing
null name/version", new Exception("Location of deprecated use, wrt "+symbolicName+":"+version+"
"+plan));
    +        if (superType==null) log.warn("Deprecated use of RegisteredTypes API passing
null supertype", new Exception("Location of deprecated use, wrt "+symbolicName+":"+version+"
"+plan));
             return addSuperType(bean(symbolicName, version, plan), superType);
         }
         
         /** Preferred mechanism for defining a spec {@link RegisteredType}.
          * Callers should also {@link #addSuperTypes(RegisteredType, Iterable)} on the result.*/
         public static RegisteredType spec(@Nonnull String symbolicName, @Nonnull String version,
@Nonnull TypeImplementationPlan plan) {
    -        if (symbolicName==null || version==null) log.warn("Deprecated use of RegisteredTypes
API passing null name/version", new Exception("Location of deprecated use, wrt "+plan));
    +        if (symbolicName==null || version==null) log.warn("Deprecated use of RegisteredTypes
API passing null supertype", new Exception("Location of deprecated use, wrt "+plan));
             return new BasicRegisteredType(RegisteredTypeKind.SPEC, symbolicName, version,
plan);
         }
    -    /** Convenience for {@link #cpec(String, String, TypeImplementationPlan)} when there
is a single known java signature/super type */
    +    /** Convenience for {@link #spec(String, String, TypeImplementationPlan)} when there
is a single known java signature/super type */
         public static RegisteredType spec(@Nonnull String symbolicName, @Nonnull String version,
@Nonnull TypeImplementationPlan plan, @Nonnull Class<?> superType) {
    -        if (superType==null) log.warn("Deprecated use of RegisteredTypes API passing
null name/version", new Exception("Location of deprecated use, wrt "+symbolicName+":"+version+"
"+plan));
    +        if (superType==null) log.warn("Deprecated use of RegisteredTypes API passing
null supertype", new Exception("Location of deprecated use, wrt "+symbolicName+":"+version+"
"+plan));
             return addSuperType(spec(symbolicName, version, plan), superType);
         }
    +    public static RegisteredType newInstance(@Nonnull RegisteredTypeKind kind, @Nonnull
String symbolicName, @Nonnull String version, 
    --- End diff --
    
    would be a good addition in future.  for now we only call it in a few places.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message