brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles
Date Mon, 10 Jul 2017 12:49:25 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/746#discussion_r126387732
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
    @@ -472,12 +524,46 @@ private void collectCatalogItems(String yaml, List<CatalogItemDtoAbstract<?,
?>>
                     if (rootItemYaml.startsWith(match)) rootItemYaml = Strings.removeFromStart(rootItemYaml,
match);
                     else rootItemYaml = Strings.replaceAllNonRegex(rootItemYaml, "\n"+match,
"");
                 }
    -            collectCatalogItems("item:\n"+makeAsIndentedObject(rootItemYaml), rootItem,
result, catalogMetadata);
    +            collectCatalogItemsFromItemMetadataBlock("item:\n"+makeAsIndentedObject(rootItemYaml),
containingBundle, rootItem, result, requireValidation, catalogMetadata, 1, force);
             }
         }
     
    +    /**
    +     * Expects item metadata, containing an `item` containing the definition,
    +     * and/or `items` containing a list of item metadata (recursing with depth).
    +     * 
    +     * Supports two modes:
    --- End diff --
    
    "... selected by parameter `requireValidation`".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message