brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles
Date Mon, 10 Jul 2017 12:49:25 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/746#discussion_r126365587
  
    --- Diff: api/src/main/java/org/apache/brooklyn/api/typereg/ManagedBundle.java ---
    @@ -27,9 +27,13 @@
     
         /** A URL-like thing that we can register with the OSGi framework
          * to uniquely identify this bundle-instance.
    -     * This typically includes the unique {@link #getId()} of this item. */
    +     * This typically includes the unique {@link #getId()} of this item. 
    +     * This will not normally be a URL that can be loaded. */
         String getOsgiUniqueUrl();
     
         VersionedName getVersionedName();
     
    +    /** MD5 checksum of the contents of bundle as installed to OSGi */
    +    String getChecksum();
    --- End diff --
    
    I'd call this `getMd5Checksum`, if that's what it is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message