brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyovcheva <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #754: Fix REST API response of methods with String ret...
Date Wed, 05 Jul 2017 08:44:38 GMT
Github user iyovcheva commented on the issue:

    https://github.com/apache/brooklyn-server/pull/754
  
    @ahgittin This is a list of the GET requests the change impacts:
    ```
    /activities/{task}/stream/{streamId}
    /applications/{application}/entities/{entity}/policies/{policy}/config
    /applications/{application}/entities/{entity}/policies/{policy}/config/current-state
    /server/user
    ```
    
    The one that was broken in the UI was `/server/user`. In this case we always expect a
single username, which makes the change not harmful in this case (if you have an example that
shows the opposite, it's well appreciated). The other option here is to change it to `text/plain`.
    
    For `/activities/{task}/stream/{streamId}` `text/plain` is always the logical option and
we ensure that json will never be expected in this case.
    
    The  controversial options IMO are the two `policies` requests. In this case the returned
string is already in json, so we may not need any changes.
    
    What do you think about:
    * Keep the change for `/activities/{task}/stream/{streamId}`
    * Change `/server/user` to `text/plain`
    * Remove `policies` changes, as this was working properly before and can be risky now?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message