Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: geomacy <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-734-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-734-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names
Content-Type: text/plain
Message-Id: <20170626134051.F1ED8E00B3@git1-us-west.apache.org>
Date: Mon, 26 Jun 2017 13:40:51 +0000 (UTC)
archived-at: Mon, 26 Jun 2017 13:40:53 -0000

Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/734#discussion_r123985528
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/location/AbstractLocation.java ---
    @@ -215,6 +216,16 @@ public AbstractLocation configure(Map<?,?> properties) {
                 config().removeKey(PARENT_LOCATION);
             }
     
    +        // allow config keys to be set by name (or deprecated name)
    +        //
    +        // Aled thinks it would be sensible to remove the consumed flags below (i.e. properties = ...).
    +        // However, that caused ClockerDynamicLocationPatternTest to fail because there is a field of 
    +        // StubContainerLocation annotated with `@SetFromFlag("owner")`, as well as a config key with 
    --- End diff --
    
    You deleted that in https://github.com/apache/brooklyn-server/pull/728, does that mean you can get rid of these flags now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---