Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: m4rkmckenna <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-744-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-744-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #744: Allow catalog item to be force-updated vi...
Content-Type: text/plain
Message-Id: <20170623125555.13AFBDFE22@git1-us-west.apache.org>
Date: Fri, 23 Jun 2017 12:55:55 +0000 (UTC)
archived-at: Fri, 23 Jun 2017 12:55:57 -0000

Github user m4rkmckenna commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/744#discussion_r123740886
  
    --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/CatalogApi.java ---
    @@ -67,7 +67,7 @@
                 @ApiResponse(code = 400, message = "Error processing the given YAML"),
                 @ApiResponse(code = 201, message = "Catalog items added successfully")
         })
    -    public Response create(String yaml);
    +    public Response create(String yaml, @QueryParam("forceUpdate") @DefaultValue("false") boolean forceUpdate);
    --- End diff --
    
    Can you add `@ApiParam(***)` so that the swagger doc has some detail


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---