brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] brooklyn-server pull request #730: Use enricher spec instead of constructor
Date Mon, 12 Jun 2017 01:17:05 GMT
GitHub user aledsage opened a pull request:

    Use enricher spec instead of constructor

    Changes (mostly test) code to use `EnricherSpec` to create enrichers, rather than calling
the enricher's constructor. As for, there
are two big reasons for doing this:
    1. the `EnricherSpec` approach is the same as is used by yaml blueprints - by using/testing
in this way, we are more confident that we'll be able to do the same in yaml blueprints.
    2. we want to simplify our code - reducing the number of ways a policy/enricher/location/entity
can be created and configured will give us some simplification.
    This PR also deletes some deprecated enrichers. They were not written in a way that was
compatible with persisted state, so I believe we won't impact any users who have these persisted.

You can merge this pull request into a Git repository by running:

    $ git pull use-EnricherSpec-instead-of-constructor

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #730


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message