brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #748: Catalog internal references
Date Wed, 28 Jun 2017 17:02:51 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/748#discussion_r124597929
  
    --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ReferencedYamlTest.java
---
    @@ -142,7 +192,7 @@ public void testYamlUrlReferencingCallerCatalogItem() throws Exception
{
                 "    version: " + TEST_VERSION,
                 "    item:",
                 "      services:",
    -            "      - type: classpath://yaml-ref-parent-catalog.yaml");
    +            "      - type: classpath://yaml-ref-catalog.yaml");  // this references yaml.basic
above
    --- End diff --
    
    Wow, I didn't no we supported this. Why?!
    
    It looks like `classpath://yaml-ref-catalog.yaml` contains:
    ```
    name: Basic app
    services:
    - name: service
      type: yaml.basic:0.1.2
    ```
    so it's not a catalog item. Should we really be able to reference it as a type in a catalog
item like this? I'd have thought the right way of doing it (for an end-user) would be to re-write
`yaml-ref-catalog.yaml` as a catalog item, deploy it to the catalog, and then reference its
type in the normal way (which clearly would invalidate this test case).
    
    I suggest we deprecate this asap. I don't think we've documented it anywhere, so hopefully
no-one is relying on it in anger.
    
    I therefore think it's not worth fixing this test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message