brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #747: BROOKLYN-520: better error if type missin...
Date Wed, 28 Jun 2017 16:38:39 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/747#discussion_r124592211
  
    --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java
---
    @@ -130,6 +132,12 @@ public static BrooklynComponentTemplateResolver newInstance(BrooklynClassLoading
     
             private static BrooklynComponentTemplateResolver newInstance(BrooklynClassLoadingContext
context, ConfigBag attrs, AbstractResource optionalTemplate) {
                 String type = getDeclaredType(null, optionalTemplate, attrs);
    +            if (type == null) {
    --- End diff --
    
    Thanks @Graeme-Miller - I've changed that and squashed it to a single commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message