brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <>
Subject [GitHub] brooklyn-server pull request #740: New versioning rules prep
Date Wed, 28 Jun 2017 10:55:40 GMT
Github user ahgittin commented on a diff in the pull request:
    --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/text/
    @@ -140,6 +147,32 @@ public int compare(String a, String b) {
                     if ((result = compareRight(a.substring(ia), b.substring(ib))) != 0) {
                         return result;
    +                // numeric portion is the same; previously we incremented and checked
    --- End diff --
    i noticed some behaviour which i thought was undesired behaviour of `NaturalOrderComparator`,
as indicated by the new tests

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message