brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names
Date Mon, 26 Jun 2017 13:40:55 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/734#discussion_r123979478
  
    --- Diff: core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java ---
    @@ -421,14 +430,22 @@ public Object getStringKey(String key) {
             return get(preferredKey);
         }
     
    -    /** convenience for @see #getWithDeprecation(ConfigKey[], ConfigKey...) */
    +    /**
    +     * Convenience for @see #getWithDeprecation(ConfigKey[], ConfigKey...).
    +     * 
    +     * @deprecated since 0.12.0; instead define deprecated names on key, see {@link ConfigKey#getDeprecatedNames()}
    +     */
         public Object getWithDeprecation(ConfigKey<?> key, ConfigKey<?> ...deprecatedKeys)
{
             return getWithDeprecation(new ConfigKey[] { key }, deprecatedKeys);
         }
     
    -    /** returns the value for the first key in the list for which a value is set,
    +    /**
    +     * Returns the value for the first key in the list for which a value is set,
          * warning if any of the deprecated keys have a value which is different to that
set on the first set current key
    -     * (including warning if a deprecated key has a value but no current key does) */
    +     * (including warning if a deprecated key has a value but no current key does).
    +     * 
    +     * @deprecated since 0.12.0; instead define deprecated names on key, see {@link ConfigKey#getDeprecatedNames()}
    --- End diff --
    
    Need the annotation below too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message