brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] brooklyn-server issue #742: DefaultAzureArmNetworkCreator improvements
Date Thu, 22 Jun 2017 12:45:28 GMT
Github user aledsage commented on the issue:
    @Graeme-Miller incorporated review comments. Note that I've deleted some of the `verify`
assertions. For example, I don't think it's worth calling `verify(azureComputeApi).getVirtualNetworkApi(TEST_RESOURCE_GROUP)`
if we subsequently do `verify(virtualNetworkApi)` because the only way to get the `virtualNetworkApi`
instance was to call the former method.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message