brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #715: Feature/http commnand effector improvemen...
Date Thu, 01 Jun 2017 16:36:41 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/715#discussion_r119665858
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
    @@ -71,9 +88,10 @@
         public static final ConfigKey<Map<String, String>> EFFECTOR_HTTP_HEADERS
= new MapConfigKey(String.class, "headers");
         public static final ConfigKey<Object> EFFECTOR_HTTP_PAYLOAD = ConfigKeys.newConfigKey(Object.class,
"httpPayload");
         public static final ConfigKey<String> JSON_PATH = ConfigKeys.newStringConfigKey("jsonPath",
"JSON path to select in HTTP response");
    -    public static final ConfigKey<String> PUBLISH_SENSOR = ConfigKeys.newStringConfigKey("publishSensor",
"Sensor name where to store json path extracted value");
    +    public static final ConfigKey<Map<String, String>> JSON_PATHS_AND_SENSORS
= new MapConfigKey(String.class, "jsonPathAndSensors", "json path selector and correspondant
sensor name tha will publish the json path extracted value");
    --- End diff --
    
    should `PUBLISH_SENSOR` not be deprecated rather than removed?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message