Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: Graeme-Miller <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-42-brooklyn-client@git.apache.org>
In-Reply-To: <git-pr-42-brooklyn-client@git.apache.org>
Subject: [GitHub] brooklyn-client pull request #42: Improve login handling.
Content-Type: text/plain
Message-Id: <20170525102627.1267FE029E@git1-us-west.apache.org>
Date: Thu, 25 May 2017 10:26:26 +0000 (UTC)
archived-at: Thu, 25 May 2017 10:26:28 -0000

Github user Graeme-Miller commented on a diff in the pull request:

    https://github.com/apache/brooklyn-client/pull/42#discussion_r118455814
  
    --- Diff: cli/commands/login.go ---
    @@ -53,6 +58,30 @@ func (cmd *Login) Metadata() command_metadata.CommandMetadata {
     	}
     }
     
    +
    +func (cmd *Login) promptAndReadUsername() (username string) {
    +	for username == "" {
    +		reader := bufio.NewReader(os.Stdin)
    +		fmt.Print("Enter Username: ")
    +		user, err := reader.ReadString('\n')
    +		if err != nil {
    +			error_handler.ErrorExit(err)
    +		}
    +		username = strings.TrimSpace(user)
    +	}
    +	return username
    +}
    +
    +func (cmd *Login) promptAndReadPassword() (password string) {
    +	fmt.Print("Enter Password: ")
    --- End diff --
    
    why no loop like in promptAndReadUsername?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---