brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #705: jclouds stub test: better allow config to...
Date Mon, 29 May 2017 10:43:10 GMT
GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/705

    jclouds stub test: better allow config to be overridden

    This allows sub-classes to better override the config values
    (the `jcloudsLocationConfig` can contain keys of type ConfigKey or String).
    
    Also fixes the log.debug, to say what the default value is overridden with.
    
    The motivator for this change is my use of it in a downstream project, which failed because
the overrides weren't being applied (when passed in as string keys).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server fix-stubbedJcloudsTest-config-overriding

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/705.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #705
    
----
commit b845e41c695175bcf8c8fd5660df0e2a64978146
Author: Aled Sage <aled.sage@gmail.com>
Date:   2017-05-29T10:41:32Z

    jclouds stub test: better allow config to be overridden
    
    This allows sub-classes to better override the config values
    (the `jcloudsLocationConfig` can contain keys of type ConfigKey or
    String).
    
    Also fixes the log.debug, to say what the default value is overridden 
    with.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message