brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <>
Subject [GitHub] brooklyn-server pull request #668: Minor CatalogResource and ApplicationReso...
Date Thu, 04 May 2017 19:12:34 GMT
GitHub user sjcorbett opened a pull request:

    Minor CatalogResource and ApplicationResource fixes

    CatalogResource closes ZipFiles cleanly and ApplicationResource checks the invoke-effector
permission before invoking the start effector.

You can merge this pull request into a Git repository by running:

    $ git pull entitlement

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #668
commit 25b3492e84a8812f2e8341a526bfc0fd309e15ec
Author: Sam Corbett <>
Date:   2017-05-04T18:48:25Z

    CatalogResource closes ZipFiles cleanly
    Rather than relying on it to occure in ZipFile's finaliser

commit 5e38b8396c03c219f80aa86aa15ca29ae42711be
Author: Sam Corbett <>
Date:   2017-05-04T19:10:53Z

    Make invokeEffector check in ApplicationResource before invoking effector
    The permission was caught further down the line anyway (in
    EntityChangeListenerImpl#onEffectorStarting) so this is a case of
    failing earlier than fixing a security hole.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message