brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] brooklyn-server pull request #680: Adds JcloudsLocationCustomizer hook to al...
Date Mon, 15 May 2017 12:08:59 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: software/winrm/src/main/java/org/apache/brooklyn/util/core/internal/winrm/
    @@ -86,6 +86,8 @@
                 "Size of file chunks (in bytes) to be used when copying a file to the remote
    +    ConfigKey<String> ADDITIONAL_CONNECTION_METADATA = newStringConfigKey("additional.connection.metadata",
"Can be used by a location customizer during provisioning to provide additional information,
which in turn can be consumed by a custom ssh tool");
    --- End diff --
    Personal preference for splitting onto multiple lines when it's this crazy-long a line.
Otherwise, it's hard to tell if there's a default value or anything like that lurking at the
very end. I'd go for one line per arg.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message