brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #680: Adds JcloudsLocationCustomizer hook to al...
Date Mon, 15 May 2017 12:08:59 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/680#discussion_r116473296
  
    --- Diff: software/winrm/src/main/java/org/apache/brooklyn/util/core/internal/winrm/WinRmTool.java
---
    @@ -86,6 +86,8 @@
                 "Size of file chunks (in bytes) to be used when copying a file to the remote
server", 
                 1024);
     
    +    ConfigKey<String> ADDITIONAL_CONNECTION_METADATA = newStringConfigKey("additional.connection.metadata",
"Can be used by a location customizer during provisioning to provide additional information,
which in turn can be consumed by a custom ssh tool");
    --- End diff --
    
    Perhaps word as something like "Can be used to pass additional custom data to the `WinrmTool`,
which is especially useful if writing a bespoke tool implementation."
    
    Your description is accurate for your use-case, but really it's not specific to the customizer
- it could be passed in as normal location config or entity `provisioning.properties`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message