brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #638: Add support for managing enrichers within...
Date Fri, 05 May 2017 14:17:01 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/638#discussion_r114989208
  
    --- Diff: policy/src/main/java/org/apache/brooklyn/policy/ha/ServiceFailureDetector.java
---
    @@ -55,7 +56,7 @@
      * (or until another process manually sets {@link Attributes#SERVICE_STATE_ACTUAL} to
{@value Lifecycle#ON_FIRE},
      * which this enricher will not clear until all problems have gone away)
      */
    -//@Catalog(name="Service Failure Detector", description="HA policy for deteting failure
of a service")
    +@Catalog(name="Service Failure Detector", description="Emits a new sensor if the current
entity has an issue")
    --- End diff --
    
    "has an issue" seems too general, would simply `if the current entity fails` be better?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message