brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graeme-Miller <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #605: Add series of meta effectors for composite opera...
Date Fri, 05 May 2017 12:32:45 GMT
Github user Graeme-Miller commented on the issue:

    https://github.com/apache/brooklyn-server/pull/605
  
    @grkvlt this PR is rather large, and missing tests. I suggest it is closed for now and
we work out a way to break this down.
    
    Some ideas for how to break it down:
    *) Separate PR's per effector would be nice
    *) New sensor types as separate PRs (e.g. AbstractCompositeEffector/PeriodicEffectorPolicy.java)
    *) Refactors as separate PRs (Moving AddSensor)
    
    This should make it easier to review and merge.
    
    What are your thoughts on this?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message