brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #664: Add contributing guidelines and PR template
Date Wed, 03 May 2017 10:01:54 GMT
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/664
  
    @tbouron Yes, I find it patronising to give comments to tell people what to put in a title
and a description, and to expect them to tick a box to say `[ ] I have read the [**CONTRIBUTING**](../CONTRIBUTING.md)
document.`.
    
    This PR neglects most of the process it advises (jira? motivation? testing? checklist?)
-- suggesting it is just process for process's sake which I abhor.
    
    I did wonder whether the `CONTRIBUTING.md` file got treated specially.  Even so it introduces
more stuff the contributor has to look at, plus stuff for us to maintain, and files littering
the root of a project -- meanwhile I'm not aware of actual problems we are encountering that
this would solve.
    
    The plain simple approach we currently have lets contributors focus on their content without
distraction.
    
    I'm strongly against any introduction of more process or bloat like this unless we have
a clear problem that we expect it to solve.
    
    @drigodwin Where there are aspects of a PR that are sub-optimal -- such as a vague title
-- you are quite right to raise it.  But in the first instance it should be mentioned it in
the PR where it arises.  if it's systemic send an email to the list to discuss, and on list
we can decide whether the situation is such we need to become a kindergarten with rules posted
blatantly in front of everyone who might be kind enough to contribute.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message