Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Subject: Re: files.customize
To: dev@brooklyn.apache.org
References: <OFA3853A50.121A1E5E-ON85258105.0045AA30-85258105.00463501@notes.na.collabserv.com>
 <a43ddbad-a871-38e8-5b26-4aa260583294@gmail.com>
Message-ID: <de7d5c7e-bf18-b9e3-660f-8cacad5f504d@CloudsoftCorp.com>
Date: Mon, 24 Apr 2017 12:18:15 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0)
 Gecko/20100101 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <a43ddbad-a871-38e8-5b26-4aa260583294@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
archived-at: Mon, 24 Apr 2017 11:18:25 -0000


+1 to copyResources being protected not private

+1 to adding `templates.customize` and `files.customize` a la 
`{templates,files}.runtime` (but before `customize.command`)


Graham if you're able to do either or both in a PR I'll see it's added 
as quickly as possible.  If not we'll pick this up soon as you're right, 
it's a curious omission.

Aled if we do need to cut another 0.11 RC and the PR lands in time, I'd 
say we backport this -- it seems pretty safe to me.

Best
Alex


On 24/04/2017 11:55, Aled Sage wrote:
> Hi Graham,
>
> If this is at the end of the customize phase, you could use 
> `templates.runtime`.
>
> However, I presume you want this at the start of `customize`. I agree 
> it makes sense to support that.
>
> I think I'd be fine with us making `copyResources` protected, for 
> power-users who are writing Java.
>
> We should also add config for `templates.customize` and 
> `files.customize` that will be uploaded at the start of the customize 
> phase. However, I don't think we'd get that into the Brooklyn 0.11.0 
> release as we do a feature-freeze after the first RC is produced.
>
> Could you create an "improvement" in Apache Brooklyn jira please, to 
> track this?
>
> Aled
>
>
> On 17/04/2017 13:46, Graham Ashby wrote:
>> (and templates.customize)
>>
>> As part of what I'm doing, I want to be able to send a templated
>> configuration file in the customization phase.
>> I was all prepared to write the code in my software process code, but
>> .AbstractSoftwareProcessDriver.copyResources() is private, not 
>> protected.
>>
>> What I've done is reuse copyPreInstallResources(), saving its templates
>> and files, and restoring them after I'm done.
>>
>> So, what would be really nice is to have files.customize and
>> templates.customize already taken care of.  Or make copyResources()
>> protected.
>>
>> Thanks
>> Graham
>>
>>
>