Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: neykov <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-617-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-617-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #617: Persist management plane ID
Content-Type: text/plain
Message-Id: <20170407105303.29E50E00C5@git1-us-west.apache.org>
Date: Fri,  7 Apr 2017 10:53:03 +0000 (UTC)
archived-at: Fri, 07 Apr 2017 10:53:05 -0000

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/617#discussion_r110364489
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/PeriodicDeltaChangeListener.java ---
    @@ -382,6 +401,8 @@ protected void persistNowInternal(boolean alreadyHasMutex) {
                 if (!alreadyHasMutex) persistingMutex.acquire();
                 if (!isActive() && state != ListenerState.STOPPING) return;
                 
    +            updatePlaneIdIfTimedOut();
    --- End diff --
    
    Writes to the datastore are lossy. We'll just log failures and move on. (Most) entities will get updated multiple times in their lifecycle so not a huge deal. planeId does not get updated so if the first write fails it's not available to the HA cluster at all. That's why I decided to periodically write it to the datastore. Will add a comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---