Return-Path: <dev-return-23706-archive-asf-public=cust-asf.ponee.io@brooklyn.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 41AA0200C5C
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed,  5 Apr 2017 11:44:36 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 3F030160B94; Wed,  5 Apr 2017 09:44:36 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 8643A160BA6
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  5 Apr 2017 11:44:35 +0200 (CEST)
Received: (qmail 46536 invoked by uid 500); 5 Apr 2017 09:44:32 -0000
Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.apache.org>
List-Post: <mailto:dev@brooklyn.apache.org>
List-Id: <dev.brooklyn.apache.org>
Reply-To: dev@brooklyn.apache.org
Delivered-To: mailing list dev@brooklyn.apache.org
Received: (qmail 45966 invoked by uid 99); 5 Apr 2017 09:44:32 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Apr 2017 09:44:32 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 4AF9DE0896; Wed,  5 Apr 2017 09:44:32 +0000 (UTC)
From: aledsage <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-612-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-612-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #612: BROOKLYN-460: Brooklyn Camp syntax for ad...
Content-Type: text/plain
Message-Id: <20170405094432.4AF9DE0896@git1-us-west.apache.org>
Date: Wed,  5 Apr 2017 09:44:32 +0000 (UTC)
archived-at: Wed, 05 Apr 2017 09:44:36 -0000

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/612#discussion_r109872011
  
    --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java ---
    @@ -227,7 +234,54 @@ protected Object getDecorationAttributeJsonValue(ConfigBag attrs) {
     
             @Override
             protected void addDecorationFromJsonMap(Map<?, ?> decorationJson, List<SpecParameter<?>> decorations) {
    -            throw new IllegalStateException("Not called");
    +            throw new UnsupportedOperationException("SpecParameterResolver.addDecorationFromJsonMap should never be called.");
    +        }
    +    }
    +
    +    public static class TagsResolver extends BrooklynEntityDecorationResolver<Iterable<Object>> {
    +        protected TagsResolver(BrooklynYamlTypeInstantiator.Factory instantiator) {
    +            super(instantiator);
    +        }
    +
    +        @Override
    +        public void decorate(EntitySpec<?> entitySpec, ConfigBag attrs, Set<String> encounteredRegisteredTypeIds) {
    +            if (getDecorationAttributeJsonValue(attrs) != null) {
    +                entitySpec.tagsAdd((Iterable<Object>)getDecorationAttributeJsonValue(attrs));
    +            }
    +        }
    +
    +        @Override
    +        protected String getDecorationKind() {
    +            return "Brooklyn Tags";
    +        }
    +
    +        @Override
    +        protected Object getDecorationAttributeJsonValue(ConfigBag attrs) {
    --- End diff --
    
    As said earlier, I'd declare the return type as `Iterable<Object>` to avoid the cast in the caller.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---