Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: sjcorbett <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-42-brooklyn-client@git.apache.org>
In-Reply-To: <git-pr-42-brooklyn-client@git.apache.org>
Subject: [GitHub] brooklyn-client pull request #42: Improve login handling.
Content-Type: text/plain
Message-Id: <20170404134117.9CE82DFE34@git1-us-west.apache.org>
Date: Tue,  4 Apr 2017 13:41:17 +0000 (UTC)
archived-at: Tue, 04 Apr 2017 13:41:19 -0000

Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/brooklyn-client/pull/42#discussion_r109663969
  
    --- Diff: cli/commands/login.go ---
    @@ -84,7 +100,8 @@ func (cmd *Login) Run(scope scope.Scope, c *cli.Context) {
     			error_handler.ErrorExit(err)
     		}
     		fmt.Printf("\n")
    -		cmd.network.BrooklynPass = string(bytePassword)
    +		password := string(bytePassword)
    +		cmd.network.BrooklynPass = strings.TrimSpace(password)
    --- End diff --
    
    Is trimming spaces the right thing to do? What if my password is " password1 "?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---