brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From drigodwin <>
Subject [GitHub] brooklyn-library pull request #99: Update random passwords
Date Thu, 13 Apr 2017 17:17:44 GMT
GitHub user drigodwin opened a pull request:

    Update random passwords

    `Strings.makeRandomId` uses a insecure random so we shouldn't be using it for passwords,
I've swapped it to `Identifiers.makeRandomPassword` which does use secure random.

You can merge this pull request into a Git repository by running:

    $ git pull fix-random-password

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #99
commit cb237cde3ca881b75af02af2e3cf4578af691ff1
Author: Duncan Godwin <>
Date:   2017-04-13T17:12:40Z

    Fix random password


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message