brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #657: BROOKLYN-334: ascii art banner says “Ap...
Date Thu, 27 Apr 2017 20:03:11 GMT
GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/657

    BROOKLYN-334: ascii art banner says “Apache Brooklyn”

    See https://issues.apache.org/jira/browse/BROOKLYN-334
    
    Switching to:
    ```
        _                     _            ____                  _    _             
       / \   _ __   __ _  ___| |__   ___  | __ ) _ __ ___   ___ | | _| |_   _ _ __ (R)
      / _ \ | '_ \ / _` |/ __| '_ \ / _ \ |  _ \| '__/ _ \ / _ \| |/ / | | | | '_ \ 
     / ___ \| |_) | (_| | (__| | | |  __/ | |_) | | | (_) | (_) |   <| | |_| | | | |
    /_/   \_\ .__/ \__,_|\___|_| |_|\___| |____/|_|  \___/ \___/|_|\_\_|\__, |_| |_|
            |_|                                                         |___/      0.11.0
    ```
    
    That is unfortunately 85 characters long (including the 0.11.0 subscript), which is more
than the standard 80 characters (http://stackoverflow.com/questions/4651012/why-is-the-default-terminal-width-80-characters).
    
    Alternatively, we could use a smaller format such as:
    ```
        _                 _          ___              _   _           
       /_\  _ __  __ _ __| |_  ___  | _ )_ _ ___  ___| |_| |_  _ _ _  
      / _ \| '_ \/ _` / _| ' \/ -_) | _ \ '_/ _ \/ _ \ / / | || | ' \ 
     /_/ \_\ .__/\__,_\__|_||_\___| |___/_| \___/\___/_\_\_|\_, |_||_|
           |_|                                              |__/      
    ```
    
    See http://patorjk.com/software/taag/#p=display&f=Standard&t=Apache%20Brooklyn
and http://patorjk.com/software/taag/#p=display&f=Small&t=Apache%20Brooklyn
    
    Personally, I like the upper case for A and B.
    
    @rdowner what do you think?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-334

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/657.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #657
    
----
commit 61bc18e9a6ca908bc68e2e6164c170175f429aa1
Author: Aled Sage <aled.sage@gmail.com>
Date:   2017-04-27T20:01:41Z

    BROOKLYN-334: ascii art banner says “Apache Brooklyn”

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message