brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #641: [WIP] Fix sensor changes event ordering
Date Wed, 19 Apr 2017 11:54:17 GMT
GitHub user neykov opened a pull request:

    https://github.com/apache/brooklyn-server/pull/641

    [WIP] Fix sensor changes event ordering 

    Makes sure that events are fired (and thus handled) in the order the attribute is set.
Without syncronyzing the last event fired could not match the last value of the attribute
breaking the logic in the ComputeServiceIndicatorsFromChildrenAndMembers enricher.
    
    Builds on https://github.com/apache/brooklyn-server/pull/622


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/brooklyn-server fix/sensor-events-order

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/641.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #641
    
----
commit 30388c171c351273f40ea771617d96279aa1f9ad
Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Date:   2017-04-06T14:07:41Z

    Fixes integration test failures
    
    Or disables failing tests which can't be fixed now.

commit 49749488e91cb50422a0c0881c80bfef7e78bc2c
Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Date:   2017-04-06T14:11:17Z

    Adds tests which trigger the root cause leading to failures in testChildFailuresOnStartButWithQuorumCausesAppToSucceed
    
    The tests are indeterministic - fail a couple of times per 100 invocations when executing
with "mvn test" in the brooklyn-itest docker container.

commit 71e93951659ce55eab76f5fe57c9df736f89ece6
Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Date:   2017-04-07T16:31:04Z

    Fixes the deduplication logic in AbstractEnricher
    
    Could incorrectly deduplicate (for example result in setting the same value twice) when
the value is set from parallel threads.

commit d223ff0fce834620710bc3a006aaeab28322869f
Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Date:   2017-04-07T15:56:31Z

    Fixes sensor changes event ordering
    
    Makes sure that events are fired (and thus handled) in the order the attribute is set.
Without syncronyzing the last event fired could not match the last value of the attribute
breaking the logic in the ComputeServiceIndicatorsFromChildrenAndMembers enricher.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message