brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-461) Condition that always return true
Date Tue, 11 Apr 2017 09:34:41 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964076#comment-15964076
] 

ASF GitHub Bot commented on BROOKLYN-461:
-----------------------------------------

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/626

    BROOKLYN-461: fix CollectionMerger’s Ref.equals

    I think we've got away with this for so long because different objects didn't have the
same hashcode, so it rarely had to execute the equals method!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-461

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/626.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #626
    
----

----


> Condition that always return true
> ---------------------------------
>
>                 Key: BROOKLYN-461
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-461
>             Project: Brooklyn
>          Issue Type: Bug
>            Reporter: JC
>            Priority: Trivial
>
> Hi
> In recent github mirror of broolyn-server, I've found the following issue in equals implementation.
> Path: utils/common/src/main/java/org/apache/brooklyn/util/collections/CollectionMerger.java
> {code}
> 196 
> 197             @Override
> 198             public boolean equals(Object o) {
> 199                 if (!(o instanceof Ref)) {
> 200                     return false;
> 201                 }
> 202                 return ((Ref)o).obj == ((Ref)o).obj;
> 203             }
> {code}
> Line 202 should be like this?
> {code}
> 202                 return this.obj == ((Ref)o).obj;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message