brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-460) Brooklyn Camp syntax for adding tags to an entity spec
Date Wed, 05 Apr 2017 09:44:41 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956590#comment-15956590
] 

ASF GitHub Bot commented on BROOKLYN-460:
-----------------------------------------

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/612#discussion_r109870494
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/BrooklynTags.java ---
    @@ -108,6 +123,39 @@ public TraitsTag(List<Class<?>> interfaces) {
             }
         }
     
    +    public static class CampBrooklynTag implements Serializable {
    --- End diff --
    
    I'm not convinced we want to wrap the user's tag in a `CampBrooklynTag`, rather than just
adding their tag directly. I'm guessing that things behave very differently if you do `brooklyn.tags:
["hi"]` then the result is very different from doing Java `entity.tags()addTag("hi")` - i.e.
the latter has the tag "hi", whereas the former has the tag of type "CampBrooklynTag" that
wraps the string "hi".
    
    Other than being able to tell where the tag came from, what is the advantage of using
`CampBrooklynTag`?


> Brooklyn Camp syntax for adding tags to an entity spec
> ------------------------------------------------------
>
>                 Key: BROOKLYN-460
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-460
>             Project: Brooklyn
>          Issue Type: New Feature
>            Reporter: Valentin Aitken
>            Priority: Minor
>
> Current requirement is to be able to supply String tags in an entity spec in YAML so
it can be then retrieved via REST API with {{GET /v1/applications/<appId>/entities/<entityId>/tags}}.
> Example usage in a YAML blueprint:
> {noformat}
> services:
> - type: org.apache.brooklyn.entity.software.base.VanillaSoftwareProcess
>   brooklyn.tags:
>   - tag1
>   - tag2
> {noformat}
> Please shout if you have further requirements for {{brooklyn.tags}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message