brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #645: Persist OSGi bundles
Date Fri, 28 Apr 2017 09:45:03 GMT
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/645
  
    @geomacy Great test.  I've been trying it and I find one good thing and several problems.
    
    The good:  deployment, persistence, versioning, etc all work smoothly in this fairly complex
example, with the exception of icons.
    
    The bad:
    * the OSGi syntax `classpath://io.cloudsoft.cli44:plane.png` does not seem to work, neither
before nor after rebind -- not sure why
    * local bundle syntax `classpath://plane.png` (which should be preferred here) also does
not work, not even before rebind -- easy to see that the `getIconUrl()` isn't using the entity's
classpath, and _I have a confirmed fix for this_
    * in above case, icon is not available after rebind -- it isn't being persisted
    * if there is no icon on the entity instance possibly it should defer to the catalog item
(not sure) which would allow it to work even if not persisted -- need to look more at this
    
    I suggest we handle this as a bug in icons as I suspect these were mostly if not all true
prior to this PR.
    
    Merge?  I'll see if I can get an icon PR out today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message